Implement basic A2A demo for ACK-ID identity exchange#11
Merged
Conversation
domleboss97
approved these changes
Jun 25, 2025
| @@ -0,0 +1,155 @@ | |||
| import { generateKeypair } from "@agentcommercekit/keys" | |||
| import { verifyJWT } from "did-jwt" | |||
Collaborator
There was a problem hiding this comment.
nit - night be easier to scan the tests if this was imported as verifyJwtBase or something. verifyJWT vs verifyJwt is a bit of a subtle difference.
Contributor
Author
There was a problem hiding this comment.
I believe I covered everything, was there any that you noticed?
| "devDependencies": { | ||
| "@repo/eslint-config": "workspace:*", | ||
| "@repo/typescript-config": "workspace:*", | ||
| "a2a-js": "^0.2.0", |
Collaborator
There was a problem hiding this comment.
is adding it as a dev dependency required here?
Contributor
Author
There was a problem hiding this comment.
This is because we have it listed as a peerDependency as well, so it's best to also include in devDependencies, but technically not required. I believe it would be fine without listing as a peerDep as well in many package managers because ack-id does it, but wanted to be sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new demo showcasing how two agents using A2A can securely exchange their identity information using ACK-ID.
This PR also provides additional tools via
agentcommercekitand@agentcommercekit/ack-idpackages (viaagentcommercekit/a2aand@agentcommercekit/ack-id/a2a) to begin using these methods in real world A2A agents.